Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token pagination #3384

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: token pagination #3384

merged 1 commit into from
Dec 8, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 7, 2022

Closes #3362

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3384 (8d7073c) into master (d275ad6) will decrease coverage by 0.20%.
The diff coverage is 47.69%.

@@            Coverage Diff             @@
##           master    #3384      +/-   ##
==========================================
- Coverage   76.95%   76.75%   -0.21%     
==========================================
  Files         123      123              
  Lines        9044     9076      +32     
==========================================
+ Hits         6960     6966       +6     
- Misses       1655     1668      +13     
- Partials      429      442      +13     
Impacted Files Coverage Δ
consent/strategy_default.go 69.59% <41.37%> (-1.34%) ⬇️
jwk/aead.go 56.52% <42.85%> (-8.19%) ⬇️
driver/config/provider_fosite.go 82.35% <50.00%> (-7.90%) ⬇️
driver/config/provider.go 82.55% <66.66%> (-0.58%) ⬇️
driver/registry_base.go 85.93% <66.66%> (-0.61%) ⬇️
persistence/sql/persister_oauth2.go 82.88% <0.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit e8d8de9 into master Dec 8, 2022
@aeneasr aeneasr deleted the fix-3362 branch December 8, 2022 11:11
@MOZGIII
Copy link
Contributor

MOZGIII commented Dec 28, 2022

I'm on hydra 2.0.3, this is supposed to be in, right?

I'm still getting this:

$ hydra list oauth2-clients -e http://localhost:4445 --format json
{"items":[],"next_page_token":"eyJvZmZzZXQiOiIxMDAiLCJ2IjoyfQ","is_last_page":false}
$ hydra list oauth2-clients -e http://localhost:4445 --format json --page-token eyJvZmZzZXQiOiIxMDAiLCJ2IjoyfQ
{"items":[],"next_page_token":"eyJvZmZzZXQiOiIyMDAiLCJ2IjoyfQ","is_last_page":false}

Is is_last_page supposed to be false?

harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken pagination using page_token in Ory Hydra APIs
2 participants