Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps #3506

Merged
merged 1 commit into from May 2, 2023
Merged

chore: bump deps #3506

merged 1 commit into from May 2, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented May 2, 2023

This should speed up INSERTs a good bit by bumping the pop dependency. Currently, we're creating a prepared statement for each insert, which is discarded immediately afterwards.

gobuffalo/pop#807

@alnr alnr requested a review from hperl May 2, 2023 12:48
@alnr alnr self-assigned this May 2, 2023
@alnr alnr requested a review from aeneasr as a code owner May 2, 2023 12:48
@kmherrmann
Copy link
Contributor

Great!
Any indication on how much we'll gain from this?

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #3506 (7a9f002) into master (b71a36b) will not change coverage.
The diff coverage is n/a.

❗ Current head 7a9f002 differs from pull request most recent head fe4e0be. Consider uploading reports for the commit fe4e0be to get more accurate results

@@           Coverage Diff           @@
##           master    #3506   +/-   ##
=======================================
  Coverage   76.89%   76.89%           
=======================================
  Files         124      124           
  Lines        9102     9102           
=======================================
  Hits         6999     6999           
  Misses       1660     1660           
  Partials      443      443           

@alnr
Copy link
Contributor Author

alnr commented May 2, 2023

Great! Any indication on how much we'll gain from this?

Not right now. Once we have benchmarks we can compare to the status quo.

@aeneasr aeneasr merged commit 31b9e66 into master May 2, 2023
31 checks passed
@aeneasr aeneasr deleted the bump-herodot branch May 2, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants