Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't duplicate dsn if its provided by extraEnvs #689

Merged
merged 4 commits into from
Jun 11, 2024
Merged

feat: don't duplicate dsn if its provided by extraEnvs #689

merged 4 commits into from
Jun 11, 2024

Conversation

Demonsthere
Copy link
Collaborator

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Demonsthere Demonsthere marked this pull request as ready for review June 11, 2024 13:34
@Demonsthere Demonsthere merged commit e2798e0 into ory:master Jun 11, 2024
19 checks passed
@Demonsthere Demonsthere deleted the feat/dsn-deduplication branch June 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Demonsthere