fix: validate subjects before mapping (#1039)

ory · Sep 29, 2022 · 71b30c4 · 71b30c4
1 parent 3724528
commit 71b30c4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/internal/relationtuple/uuid_mapping.go b/internal/relationtuple/uuid_mapping.go
@@ -202,6 +202,9 @@ func (m *Mapper) FromTuple(ctx context.Context, ts ...*ketoapi.RelationTuple) (r
 		}
 		i := len(res)
 
+		if err := t.Validate(); err != nil {
+			return nil, err
+		}
 		if t.SubjectID != nil {
 			s = append(s, *t.SubjectID)
 			onSuccess.do(func() {

diff --git a/internal/relationtuple/uuid_mapping_test.go b/internal/relationtuple/uuid_mapping_test.go
@@ -47,6 +47,17 @@ func TestMapper(t *testing.T) {
 					},
 				},
 			},
+			{
+				name: "relation tuple without subject",
+				rts: []*ketoapi.RelationTuple{
+					{
+						Namespace: nspace.Name,
+						Object:    "object",
+						Relation:  "relation",
+					},
+				},
+				err: ketoapi.ErrNilSubject,
+			},
 			{
 				name: "many relation tuples",
 				rts: func() []*ketoapi.RelationTuple {