Keto expand REST API does not parse query parameter max-depth correctly

[counter2015]

Describe the bug

Keto exapnd REST API will return http code 400 when there is not max-depth in query parameter.

Reproducing the bug

keto/internal/expand/handler.go

Lines 77 to 82 in d766968

	func (h *handler) getExpand(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
	depth, err := strconv.ParseInt(r.URL.Query().Get("max-depth"), 0, 0)
	if err != nil {
	h.d.Writer().WriteError(w, r, herodot.ErrBadRequest.WithError(err.Error()))
	return
	}

Expected behavior

It should behave as doc says that max-depth is not required.

Or it should be consistent with cli behavior, that's to say, has a default value

$ keto expand grant role company-admin

∪ role:company-admin#grant
├─ ☘ role:super-admin️
├─ ∪ role:super-admin#member
│  ├─ ☘ user:ZhangThree️

Environment

• Version: 0.6.0-alpha.3
• Environment: Docker compose, PostMan

[zepatrik]

True, as it is a query parameter it should not be required but come with a default. Should have the same default value everywhere, so CLI, REST handler, and gRPC handler.

[Lumexralph]

@zepatrik I would also like to look into this issue but not until the other issue I am working on is resolved.

[AshirwadPradhan]

Hi, I would like to work on this issue. Is there anyone else working on it ?

[CypherpunkSamurai]

I have added a PR #755 that hopefully solves this issue. max-depth is now required as confirmed by @zepatrik

The strconv.ParseInt() function call on line 78 recieved null string from url.Query().Get(). This caused exception that was also handled as any other error.

This was an unintended error but worked just as required 😆

I made few changes that clean it for better understanding.

Happy Hacktoberfest to Everyone 😄