Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update tags in quickstart before release #3268

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented May 5, 2023

Currently we update them after release, which means that the quickstart as described in the docs does not work:

git checkout v0.13.0
grep "oryd/kratos" quickstart.yml 
    image: oryd/kratos:v0.11.1
    image: oryd/kratos-selfservice-ui-node:v0.11.1
    image: oryd/kratos:v0.11.1

which in turn leads to issues like #3267

Blocked by ory/cli#308

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #3268 (6fbf7a9) into master (a1fea6c) will not change coverage.
The diff coverage is n/a.

❗ Current head 6fbf7a9 differs from pull request most recent head 64319c5. Consider uploading reports for the commit 64319c5 to get more accurate results

@@           Coverage Diff           @@
##           master    #3268   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files         324      324           
  Lines       20762    20762           
=======================================
  Hits        16225    16225           
  Misses       3331     3331           
  Partials     1206     1206           

@vinckr vinckr mentioned this pull request May 8, 2023
6 tasks
@vinckr vinckr mentioned this pull request Jun 26, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant