Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor decisions API and add traefik #486

Merged
merged 12 commits into from Jul 29, 2020
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 29, 2020

Closes #265 and #263

mvanderlee and others added 10 commits April 6, 2020 11:30
Behaves identical to /decisions except that it gets the url and method from the headers.
This allows integration with Traefik's ForwardAuth middleware.
Ensure we only accept GET for /decisions/traefik
Refactors the decisions API location from `/decisions` to `/decisions/traefik`.
Additionally, an endpoint `/decisions/traefik` has been added for integration with the Traefik proxy.

Closes #263

BREAKING CHANGE: Please update `/decisions` to `/decisions/generic` in all applications that use the ORY Oathkeeper Decisions API.
@aeneasr aeneasr self-assigned this Jul 29, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aeneasr
❌ Michiel Vanderlee


Michiel Vanderlee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aeneasr aeneasr added this to the v0.39.0 milestone Jul 29, 2020
@aeneasr aeneasr added this to In progress in Maintainer's Board via automation Jul 29, 2020
@aeneasr aeneasr merged commit bdd1ca8 into next-gen Jul 29, 2020
Maintainer's Board automation moved this from In progress to Done Jul 29, 2020
@aeneasr aeneasr mentioned this pull request Jul 29, 2020
6 tasks
@aeneasr aeneasr deleted the traefik-auth-forward-2 branch July 29, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants