Align CI workflows from os-autoinst-common and isotovideo #28
Conversation
scripts/validate-test-results
Outdated
| my @test_results_to_check = (); | ||
|
|
||
| while(@args){ | ||
| my $arg = shift @args; |
There was a problem hiding this comment.
no tabs please :)
Isn't this file linted itself?
There was a problem hiding this comment.
Next change after perltidy on os-autoinst-commons is a generic perltidy & perl critic workflow that can be used like the git commit checker.
as per my experiments here: https://github.com/josegomezr/perl-toolkit
There was a problem hiding this comment.
Next to the already stated comment there is also the git commit message which does not adhere to the style that the git commit message checker would actually check. After you fixed all comments an the git commit message I will need to take another look so there might be more open points.
josegomezr
force-pushed
the
simplify_example_pipeline
branch
from
071cce2
to
68ef8d6
Compare
Where? What's missing? |
josegomezr
force-pushed
the
simplify_example_pipeline
branch
2 times, most recently
from
8042abb
to
764f064
Compare
josegomezr
force-pushed
the
simplify_example_pipeline
branch
2 times, most recently
from
1110758
to
7aced50
Compare
|
Phrase git commit message subject lines in imperative mood, e.g. s/Linting & Improved workflows/Add CI workflows from os-autoinst-common/ or something like that |
josegomezr
changed the title
josegomezr
force-pushed
the
simplify_example_pipeline
branch
2 times, most recently
from
e7fb8ac
to
5949005
Compare
There was a problem hiding this comment.
I don't understand how the changes align to
Regarding the actual changes I don't think it's a wise idea to build in that much reliance on github actions. As much as possible I would like us to stay independant of the actual CI use and keep commands that we call in there as simple as possible. That's why I prefer a command like
podman run --rm -it -v .:/tests:Z registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86 qemu_no_kvm=1 casedir=/tests
to the rather verbose extended results you do.
Please also see my inline comments.
Nothing prevents you from that. it's written on "GitHub Actions" lang sort-of-speak. But you can get to do the podman run, and that invocation style should be documented where |
You have to keep in mind that os-autoinst-distri-example is used as example as well as template for new users and new test distributions. Also see what https://github.com/os-autoinst/os-autoinst-distri-example/blob/main/README.md tells about that. Regarding the CI workflow please also see http://open.qa/docs/#_create_and_monitor_openqa_jobs_from_within_the_ci_runner where we reference the github workflow definitions from os-autoinst-distri-example |
- Brought the commit message checker workflow from os-autoinst-commons.
josegomezr
force-pushed
the
simplify_example_pipeline
branch
from
df13f59
to
3bba4dd
Compare
|
As discussed today, Bringing the commit message from commons only. |
Complements os-autoinst/os-autoinst-commons#30
poo#138416