Make isotovideo workflows more GitHub Native #29
Conversation
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Run isotovideo against test code in happy-path scenario | ||
| run: podman run --rm -it -v .:/tests:Z registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86 qemu_no_kvm=1 casedir=/tests |
There was a problem hiding this comment.
As explained in #28 on multiple places, in particular #28 (comment) , I am not convinced we should do that change from a single podman call to a github workflow specific syntax. There are of course some advantages but as disadvantages I see that people can not just copy-paste that line to reproduce. I would go even further and extract that line into a Makefile so that github CI same as users can just call make test-isotovideo-happy-path without duplication.
.github/workflows/openqa.yml
Outdated
| if [[ -z "$OPENQA_API_KEY" && -z "$OPENQA_API_SECRET" ]]; then | ||
| echo "Skipping openQA scheduling step: No API Keys configured." | ||
| echo "Configure OPENQA_API_KEY & OPENQA_API_SECRET secrets" | ||
| exit 0 | ||
| fi | ||
|
|
There was a problem hiding this comment.
If this fails without error then tests would be silently skipped. I don't think this is a good idea
There was a problem hiding this comment.
Failing it always is not a good idea either, what about scheduling only if the envs are set?
There was a problem hiding this comment.
What's the motivation to use this workflow without valid credentials? That feels wrong
There was a problem hiding this comment.
quick heads up: on Jan 14th I added an optional clause for the workflow so it's not scheduled.
7982db8#diff-de0e4ae603aa915aebe97e563c4ffe51dfe10881cc9904c4dfe0c39faebbffd6R22
josegomezr
force-pushed
the
native_gha
branch
from
d5c8d46
to
7982db8
Compare
josegomezr
force-pushed
the
native_gha
branch
from
7982db8
to
1d51542
Compare
|
Removed |
.github/workflows/isotovideo.yml
Outdated
| # see: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-expanding-configurations | ||
| isotovideo-args: | ||
| - "--exit-status-from-test-results qemu_no_kvm=1 casedir=." | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Is there a reason to run it on older ubuntu version?
There was a problem hiding this comment.
none whatsoever, I seem to recall ubuntu-latest was not the real latest when I started it. I'll throw in ubuntu-latest and see how it behaves
josegomezr
force-pushed
the
native_gha
branch
from
20911ac
to
bd5b5af
Compare
- Improved isotovideo example workflow, it can be easily extended
with a matrix as per GitHub Actions docs [0].
It brings:
- A perl script for checking the test results, to remove `jq`
usages.
- Pipeline Artifacts, it's possible to inspect the test
results after a run.
And now the example workflow is green and not repeated.
- Skip job openQA if credentials are not configured.
[0]: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-expanding-configurations
Co-authored-by: Martchus <martchus@gmx.net>
Co-authored-by: Tina Müller <cpan2@tinita.de>
Co-authored-by: Oliver Kurz <okurz@suse.de>
josegomezr
force-pushed
the
native_gha
branch
from
bd5b5af
to
ed4c006
Compare
Improved isotovideo example workflow, it can be easily extended with a matrix as per GitHub Actions docs 0.
It brings:
jqusages. Shouldisotovideoprovide that feature, the script can be discarded.And now the example workflow is green and not repeated.
Skip job openQA if credentials are not configured
poo#138416
The example action now starts green.