Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable firstboot_hostname in first boot test #10856

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

JRivrain
Copy link
Contributor

@JRivrain JRivrain commented Aug 20, 2020

This change also aims to allow testing other firstboot clients, see
motivation here https://progress.opensuse.org/issues/69130

Passed 50 test runs

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very promising!

@JRivrain JRivrain force-pushed the firstboot_hostname branch 2 times, most recently from ea11ea9 to 7eea0bc Compare August 25, 2020 16:27
schedule/yast/firstboot/yast2_firstboot_custom.yaml Outdated Show resolved Hide resolved
schedule/yast/firstboot/autoyast_y2_firstboot_custom.yaml Outdated Show resolved Hide resolved
test_data/yast/firstboot/yast2_firstboot_custom.yaml Outdated Show resolved Hide resolved
tests/installation/enable_y2_firstboot.pm Outdated Show resolved Hide resolved
tests/installation/enable_y2_firstboot.pm Show resolved Hide resolved
tests/installation/yast2_firstboot.pm Outdated Show resolved Hide resolved
@JRivrain JRivrain force-pushed the firstboot_hostname branch 3 times, most recently from fa619a1 to f36fd61 Compare August 28, 2020 13:00
@JRivrain JRivrain force-pushed the firstboot_hostname branch 6 times, most recently from a020aba to cebce66 Compare August 28, 2020 15:03
@rwx788
Copy link
Member

rwx788 commented Sep 1, 2020

Looks like we again have issues with tidy: Wrong version of perltidy. Found '20200619', expected '20200822' ...
Let's see if there is already PR with the fix.

@rwx788
Copy link
Member

rwx788 commented Sep 1, 2020

Looks like we again have issues with tidy: Wrong version of perltidy. Found '20200619', expected '20200822' ...
Let's see if there is already PR with the fix.

Other PR from @b10n1k worked fine now: https://travis-ci.org/github/os-autoinst/os-autoinst-distri-opensuse/builds/723116973
Could you please pull and rebase from master, so you get this change #10929 in?

Related ticket https://progress.opensuse.org/issues/69175
This change also aims to allow testing other firstboot clients, see
motivation here https://progress.opensuse.org/issues/69130
@JRivrain JRivrain changed the title [WIP] Enable firstboot_hostname in first boot test Enable firstboot_hostname in first boot test Sep 2, 2020
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwx788 rwx788 merged commit 1ab207a into os-autoinst:master Sep 2, 2020
JRivrain added a commit to JRivrain/os-autoinst-needles-opensuse that referenced this pull request Sep 2, 2020
See relaed PR os-autoinst/os-autoinst-distri-opensuse#10856

 Veuillez saisir le message de validation pour vos modifications. Les lignes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants