Add clients in firstboot_custom #12290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRivrain
force-pushed
the
firstboot_libyui
branch
from
455a6e1
to
1ca8b8a
Compare
JRivrain
added a commit
to JRivrain/os-autoinst-needles-opensuse
that referenced
this pull request
Apr 15, 2021
See os-autoinst/os-autoinst-distri-opensuse#12290 For some reason, certain elements end-up (un)selected when we change the order of clients. It does not disturb change the workflow but needles are then different
JRivrain
force-pushed
the
firstboot_libyui
branch
from
1ca8b8a
to
813f766
Compare
JRivrain
changed the title
jknphy
reviewed
Apr 16, 2021
JRivrain
force-pushed
the
firstboot_libyui
branch
2 times, most recently
from
3e1e89e
to
588f821
Compare
rwx788
reviewed
Apr 19, 2021
There was a problem hiding this comment.
Good job here, small request, could you please update https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/blob/master/SLES_Integration_Level_Testplan.md so that we do not forget where which firstboot clients are covered.
JRivrain
force-pushed
the
firstboot_libyui
branch
from
588f821
to
3eb6fbf
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://progress.opensuse.org/issues/73474:
In order to extend coverage for yast2-firstboot , we can modify the yast2-firstboot configuration files of the relevant test suite:
https://openqa.suse.de/tests/4840750
There already is customized file replacing /etc/YaST2/firstboot.xml after merge of:
#10856
We should re-use yast2_firstboot_custom and use non-default settings for the modules if those are allowed.
Enable firstboot_ntp, firstboot_keyboard and inst_lan modules.
related bugs: bug#1177797 , bug#960081 , bug#1140199 , bug#1101514
VRs (updated)
https://openqa.opensuse.org/tests/1701175
https://openqa.suse.de/tests/5836018