Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for screen loaded in Installation Settings #11179

Merged

Conversation

jknphy
Copy link
Contributor

@jknphy jknphy commented Oct 12, 2020

Wait for screen loaded in Installation Settings when selecting Software.

Wait for screen loaded in Installation Settings when selecting
Software.
@jknphy jknphy force-pushed the fix_select_partterns_menu_selection branch from 899fc58 to 8b5890f Compare October 13, 2020 07:03
Copy link
Contributor

@b10n1k b10n1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please double check that proper needle is available everywhere.

@jknphy
Copy link
Contributor Author

jknphy commented Oct 13, 2020

LGTM, but could you please double check that proper needle is available everywhere.

I did a wide search and test module 'select_patterns' seems to proceed always to test module 'installation_overview' where the existing needle is used, so it looks like we are safe.

@rwx788 rwx788 merged commit 86c4423 into os-autoinst:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants