Stabilize VLC test #11477
Merged
Stabilize VLC test #11477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimStar77
reviewed
Nov 25, 2020
dzedro
reviewed
Nov 27, 2020
|
|
||
| if (!check_var('QEMUVGA', 'cirrus')) { | ||
| x11_start_program('vlc --no-autoscale --loop data/test.ogv', target_match => 'vlc-playing'); | ||
| assert_and_click 'close_vlc'; |
There was a problem hiding this comment.
I'm not sure if alt-f4 does work in every DM, then needle would be not needed.
Otherwise one needle can contain close_vlc vlc-playing tags with click area, as the needle is same.
There was a problem hiding this comment.
close_vlc is already there for the existing test. I'm not really into the idea of a combined needle as it could lead to confusion.
There was a problem hiding this comment.
I guess so far, this wouldn't be a problem in the systems where VLC is being tested atm...
There was a problem hiding this comment.
Sure, but people will be very confused by many needles containing multiple tags.
foursixnine
approved these changes
Nov 27, 2020
ge0r
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needles: os-autoinst/os-autoinst-needles-opensuse#702
Ticket: https://progress.opensuse.org/issues/42773
Verification:
gnome: http://kazhua.qa.suse.de/tests/145#
kde: http://kazhua.qa.suse.de/tests/146#step/vlc/31
xfce: http://kazhua.qa.suse.de/tests/151#step/vlc/27
lxde: http://kazhua.qa.suse.de/tests/150#step/vlc/32
Not running on cirrus graphics due to issues: https://openqa.opensuse.org/tests/1483518#step/vlc/31
Video was created with: