Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize VLC test #11477

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Stabilize VLC test #11477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added data/test.ogv
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions tests/x11/vlc.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ sub run {
wait_still_screen(1);
assert_and_click 'close_vlc';
}

if (!check_var('QEMUVGA', 'cirrus')) {
x11_start_program('vlc --no-autoscale --loop data/test.ogv', target_match => 'vlc-playing');
assert_and_click 'close_vlc';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if alt-f4 does work in every DM, then needle would be not needed.
Otherwise one needle can contain close_vlc vlc-playing tags with click area, as the needle is same.

Copy link
Member Author

@asdil12 asdil12 Nov 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close_vlc is already there for the existing test. I'm not really into the idea of a combined needle as it could lead to confusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so far, this wouldn't be a problem in the systems where VLC is being tested atm...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but people will be very confused by many needles containing multiple tags.

}
}

1;