Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test module for warning when no root is set #11559

Merged

Conversation

OleksandrOrlov
Copy link
Contributor

@OleksandrOrlov OleksandrOrlov commented Dec 4, 2020

The PR is one in set of PRs to add test modules to check partitioning warnings by splitting partitioning_warnings test module.

The test module checks that Error Dialog is shown when saving
partitioning settings with no root mounted.

@OleksandrOrlov OleksandrOrlov added WIP Work in progress and removed WIP Work in progress labels Dec 4, 2020
@OleksandrOrlov OleksandrOrlov force-pushed the 78007_partitioning_warnings branch 2 times, most recently from 6e43f98 to cb91d7a Compare December 4, 2020 15:18
@sofiasyria
Copy link
Contributor

sofiasyria commented Dec 5, 2020

I think it would be faster if we just removed the root partition, accept changes and then add it after error message. But as it's not taking too long as is, LGTM . Just check the Travis failure and maybe break the lines that are longer than 120 characters. Kindly take a look here: https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/blob/master/Development_Guide.md#self-review-check-list

lib/Installation/Partitioner/ErrorDialog.pm Outdated Show resolved Hide resolved
tests/installation/partitioning/warning/no_root.pm Outdated Show resolved Hide resolved
tests/installation/partitioning/warning/no_root.pm Outdated Show resolved Hide resolved
schedule/yast/btrfs/btrfs+warnings.yaml Outdated Show resolved Hide resolved
lib/YuiRestClient/App.pm Show resolved Hide resolved
@OleksandrOrlov
Copy link
Contributor Author

OleksandrOrlov commented Dec 7, 2020

I think it would be faster if we just removed the root partition, accept changes and then add it after error message.

I also considered the faster way to do that. As I noticed, if select "Start with existing partitions" then there is not root there at all, then I can just hit "Accept" and got the error. The potential problem that I see in that case is that it breaks down the independency of the test. If the existing proposal will be different than I expect (e.g. we'll add some test module before the one), then the result might be unexpected. Maybe the issue has low potential for appearing, but I just wanted to predict it.

@OleksandrOrlov OleksandrOrlov force-pushed the 78007_partitioning_warnings branch 5 times, most recently from 5ac2872 to 63cc4b8 Compare December 8, 2020 07:14
@OleksandrOrlov OleksandrOrlov force-pushed the 78007_partitioning_warnings branch 5 times, most recently from a5f4221 to ae50de7 Compare December 8, 2020 09:27
The test module checks that Error Dialog is shown when saving
partitioning settings with no root mounted.
Copy link
Member

@foursixnine foursixnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwx788 signs with blood here.

@foursixnine foursixnine merged commit 23a1bc4 into os-autoinst:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants