-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test module for warning when no root is set #11559
Add test module for warning when no root is set #11559
Conversation
6e43f98
to
cb91d7a
Compare
I think it would be faster if we just removed the root partition, accept changes and then add it after error message. But as it's not taking too long as is, LGTM . Just check the Travis failure and maybe break the lines that are longer than 120 characters. Kindly take a look here: https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/blob/master/Development_Guide.md#self-review-check-list |
lib/Installation/Partitioner/LibstorageNG/v4_3/ExpertPartitionerController.pm
Outdated
Show resolved
Hide resolved
lib/Installation/Partitioner/LibstorageNG/v4_3/ConfirmationWarning.pm
Outdated
Show resolved
Hide resolved
cb91d7a
to
b4c9d45
Compare
I also considered the faster way to do that. As I noticed, if select "Start with existing partitions" then there is not root there at all, then I can just hit "Accept" and got the error. The potential problem that I see in that case is that it breaks down the independency of the test. If the existing proposal will be different than I expect (e.g. we'll add some test module before the one), then the result might be unexpected. Maybe the issue has low potential for appearing, but I just wanted to predict it. |
5ac2872
to
63cc4b8
Compare
lib/Installation/Partitioner/LibstorageNG/v4_3/ExpertPartitionerController.pm
Outdated
Show resolved
Hide resolved
63cc4b8
to
007b463
Compare
lib/Installation/Partitioner/LibstorageNG/v4_3/ConfirmationWarning.pm
Outdated
Show resolved
Hide resolved
007b463
to
9034753
Compare
a5f4221
to
ae50de7
Compare
The test module checks that Error Dialog is shown when saving partitioning settings with no root mounted.
ae50de7
to
4f241a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwx788 signs with blood here.
The PR is one in set of PRs to add test modules to check partitioning warnings by splitting
partitioning_warnings
test module.The test module checks that Error Dialog is shown when saving
partitioning settings with no root mounted.
sle: https://openqa.suse.de/tests/5141485
TW: https://openqa.opensuse.org/tests/1499589