Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutt test by installing packages unconditionally #12073

Merged
merged 1 commit into from Mar 19, 2021

Conversation

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you put into the description of the pull request could also be in the commit message details. I don't know how you created your pull request but your git commit messages has only the subject line while the pull request description has more details. Please keep in mind that the github pull request description is only visible on github, the commit can be considered permanent information storage.

I can recommend the tool hub (zypper in rubygem-hub) for easier PR creation. Also, I myself use a script pr-last to create a PR with proper description for these simple one-commit PRs:

$ cat $(which git-pr-last )
#!/bin/sh -e
target="${target:-"$USER"}"
git push $target && git show --no-patch --format=%B | hub pull-request -F -

See https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/CONTRIBUTING.md#coding-style for more details

Mutt is not installed by default on openSUSE, make sure to install it
before the test [poo#89260](https://progress.opensuse.org/issues/89260).
@baierjan
Copy link
Member Author

baierjan commented Mar 4, 2021

Ah, forgot to push the changed commit to this branch as well. Thanks for the tip for the cli command. I assume the second link should be git-pr-last.

@baierjan baierjan requested a review from okurz March 4, 2021 20:20
@okurz
Copy link
Member

okurz commented Mar 5, 2021

Ah, forgot to push the changed commit to this branch as well. Thanks for the tip for the cli command. I assume the second link should be git-pr-last.

thanks. I will update my github saved reply :D

@baierjan baierjan merged commit 0c14eb3 into os-autoinst:master Mar 19, 2021
@baierjan baierjan deleted the mutt branch March 19, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants