Use libyui api for yast2 lan dhcp hostname setting #12127

OleksandrOrlov · 2021-03-12T09:09:38Z

The commit rewrites yast2_lan_hostname tests to use libyui-rest-api.

Also the test cases are separated for the cases when 'no', 'yes: any'
and 'yes: eth0' are set for hostname via DHCP.

Verification runs:

The following update is required on o3 in Job Groups:

openSUSE Tumbleweed
openSUSE Tumbleweed AArch64
openSUSE Tumbleweed PowerPC
openSUSE Leap 15

- yast2_ncurses:
    settings:
       YAML_SCHEDULE: schedule/yast/yast2_ncurses/yast2_ncurses_opensuse.yaml

lib/YaST/Module.pm

jknphy

In general, I would recommend to improve the test data in this PR.

Other points:
Besides that, s/libyu/libyui/ in the title and in the commit and as discussed offline, separate the commits.
Also, in order to not forget, we have multiple implementation of the notification dialog, we should put a comment or make it more explicit that is related to use NM, should be obvious somehow from the test data/test what we are doing different there (different opening methods? just thinking loud, like open_lan_nm, open_lan, I know that that is not how you implement it, just to consider it)

lib/YaST/Module.pm

lib/YaST/NetworkSettings/ActionButtons.pm

lib/YaST/NetworkSettings/HostnameDNSTab.pm

lib/YaST/Warning/Notification.pm

schedule/yast/yast2_ncurses/yast2_ncurses_opensuse.yaml

tests/console/yast2_lan_hostname_dhcp_yes_eth.pm

jknphy · 2021-03-12T11:40:15Z

tests/console/yast2_lan_hostname_dhcp_yes_eth.pm

+    });
+    $network_settings->save_changes();
+
+    assert_screen 'console-visible', 180;


why we should still use needles, can we just change console here?

Initially I had select_console 'root' here. By the way, it also uses needles inside:)

But I had some issues with waiting and thought it is due to that. So, I returned the approach that was used in the initial yast2_lan_hostname test module. The issues were not gone:) So I can revert to select_console 'root', but I have better approach here, that I want to apply.

I want to create something like wait_for_close in YaST::Module and use wait_serial inside to check that module is closed.

I wonder if we want to promote this method and extract to some method? No need to do it now though.

tests/console/yast2_lan_hostname_dhcp_no.pm

jknphy · 2021-03-12T14:50:23Z

tests/console/yast2_lan_hostname_dhcp_no.pm

+
+    assert_screen 'console-visible', 180;
+    wait_still_screen;
+    assert_script_run 'grep DHCLIENT_SET_HOSTNAME /etc/sysconfig/network/dhcp|grep no';


btw we are already validating settings with https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/cfg_files_utils.pm, there is even some validation of network #11954

tests/security/apparmor_profile/usr_sbin_smbd.pm

lib/YaST/Warning/Notification.pm

lib/yast2_lan_hostname_base.pm

tests/console/activate_products.pm

OleksandrOrlov · 2021-03-17T15:32:12Z

lib/YaST/Module.pm

+        );
+    }
+    elsif ($ui eq 'qt') {
+        launch_yast2_module_x11('', $module, extra_vars => get_var('YUI_PARAMS'));


I introduced PR where I removed $self from launch_yast2_module_x11. So after the PR is merged, here workaround for the 1st parameter also has to be removed.
PR: #12159

rwx788

LGTM

rwx788 · 2021-03-18T07:33:09Z

Before we merge your change, could you please take a look on this failure in your VRs: https://openqa.suse.de/tests/5680628#step/yast2_lan_restart_bridge/31 Might be related to always_rollback flag being set.

OleksandrOrlov · 2021-03-18T13:18:24Z

Before we merge your change, could you please take a look on this failure in your VRs: https://openqa.suse.de/tests/5680628#step/yast2_lan_restart_bridge/31 Might be related to always_rollback flag being set.

Fixed. It was because yast2_lan_restart_* tests used save_changes method, but it was rewritten with LibyuiClient. So, I'm running the modules now with libyui-rest-api support and it works.

I also created a ticket to use LibyuiClient in the modules completely: https://progress.opensuse.org/issues/90287

schedule/yast/yast2_gui/yast2_gui_sle.yaml

The commit rewrites yast2_lan_hostname tests to use libyui-rest-api. Also the test cases are separated for the cases when 'no', 'yes: any' and 'yes: eth0' are set for hostname via DHCP. Related ticket: https://progress.opensuse.org/issues/89209

Use open() method from YaST::Module to open the YaST module.

rwx788 reviewed Mar 12, 2021

View reviewed changes

lib/YaST/Module.pm Outdated Show resolved Hide resolved

rwx788 reviewed Mar 12, 2021

View reviewed changes

lib/YaST/Module.pm Outdated Show resolved Hide resolved

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch from 198547b to cd23eb0 Compare March 12, 2021 11:06

jknphy reviewed Mar 12, 2021

View reviewed changes

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch 2 times, most recently from db48571 to 7a646cd Compare March 15, 2021 15:28

rwx788 reviewed Mar 15, 2021

View reviewed changes

tests/security/apparmor_profile/usr_sbin_smbd.pm Outdated Show resolved Hide resolved

rwx788 changed the title ~~Use libyu api for yast2 lan dhcp hostname setting~~ Use libyui api for yast2 lan dhcp hostname setting Mar 15, 2021

rwx788 reviewed Mar 15, 2021

View reviewed changes

lib/YaST/Warning/Notification.pm Outdated Show resolved Hide resolved

rwx788 reviewed Mar 15, 2021

View reviewed changes

lib/yast2_lan_hostname_base.pm Show resolved Hide resolved

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch from 7a646cd to 83ccbda Compare March 15, 2021 16:24

rwx788 reviewed Mar 16, 2021

View reviewed changes

tests/console/activate_products.pm Outdated Show resolved Hide resolved

rwx788 reviewed Mar 16, 2021

View reviewed changes

tests/console/activate_products.pm Outdated Show resolved Hide resolved

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch 3 times, most recently from 280dff0 to 0cb864e Compare March 16, 2021 10:08

OleksandrOrlov added the notready label Mar 16, 2021

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch 5 times, most recently from 64dead3 to 6c96cfb Compare March 17, 2021 14:26

OleksandrOrlov removed the notready label Mar 17, 2021

OleksandrOrlov commented Mar 17, 2021

View reviewed changes

rwx788 approved these changes Mar 17, 2021

View reviewed changes

jknphy approved these changes Mar 18, 2021

View reviewed changes

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch 2 times, most recently from 88dd3b2 to 1173d38 Compare March 18, 2021 11:21

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch 2 times, most recently from f0fef4c to 303f753 Compare March 18, 2021 11:35

jknphy reviewed Mar 19, 2021

View reviewed changes

schedule/yast/yast2_gui/yast2_gui_sle.yaml Show resolved Hide resolved

Oleksandr Orlov added 2 commits March 19, 2021 09:34

Use unified method to open expert partitioner module

c69c8bd

Use open() method from YaST::Module to open the YaST module.

OleksandrOrlov force-pushed the 89209_libyui_lan2_hostname branch from 303f753 to c69c8bd Compare March 19, 2021 08:34

sofiasyria mentioned this pull request Mar 19, 2021

Add yast2_system_settings module for yast2_gui #12181

Merged

rwx788 merged commit 52623d6 into os-autoinst:master Mar 19, 2021

OleksandrOrlov mentioned this pull request Mar 19, 2021

Remove unused $self from launch_yast2_module_x11 #12159

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use libyui api for yast2 lan dhcp hostname setting #12127

Use libyui api for yast2 lan dhcp hostname setting #12127

OleksandrOrlov commented Mar 12, 2021 •

edited

jknphy left a comment •

edited

jknphy Mar 12, 2021

OleksandrOrlov Mar 12, 2021

rwx788 Mar 16, 2021

jknphy Mar 12, 2021

OleksandrOrlov Mar 17, 2021

rwx788 left a comment

rwx788 commented Mar 18, 2021

OleksandrOrlov commented Mar 18, 2021 •

edited

Use libyui api for yast2 lan dhcp hostname setting #12127

Use libyui api for yast2 lan dhcp hostname setting #12127

Conversation

OleksandrOrlov commented Mar 12, 2021 • edited

jknphy left a comment • edited

Choose a reason for hiding this comment

jknphy Mar 12, 2021

Choose a reason for hiding this comment

OleksandrOrlov Mar 12, 2021

Choose a reason for hiding this comment

rwx788 Mar 16, 2021

Choose a reason for hiding this comment

jknphy Mar 12, 2021

Choose a reason for hiding this comment

OleksandrOrlov Mar 17, 2021

Choose a reason for hiding this comment

rwx788 left a comment

Choose a reason for hiding this comment

rwx788 commented Mar 18, 2021

OleksandrOrlov commented Mar 18, 2021 • edited

OleksandrOrlov commented Mar 12, 2021 •

edited

jknphy left a comment •

edited

OleksandrOrlov commented Mar 18, 2021 •

edited