Remove unused $self from launch_yast2_module_x11 #12159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, is ready? |
The commit removes $self from the function as a first parameter, as it is does not share any context with the package where it is defined. Also $self is not used inside the function.
OleksandrOrlov
force-pushed
the
launch_yast2_module_x11
branch
from
6a4128c
to
170dc77
Compare
It is ready now, as I waited for #12127 to be merged first. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit removes $self from the function as a first parameter, as it
is does not share any context with the package where it is defined.
Also $self is not used inside the function.