sssd remove use of python-pam #12179
Conversation
| # Install test subjects and test scripts | ||
| my @test_subjects = qw( | ||
| sssd sssd-krb5 sssd-krb5-common sssd-ldap sssd-tools | ||
| openldap2 openldap2-client | ||
| krb5 krb5-client krb5-server krb5-plugin-kdb-ldap | ||
| ); | ||
|
|
||
| # for sle 12 we still use and support python2 |
There was a problem hiding this comment.
Update also test description
There was a problem hiding this comment.
Good catch! Updated.
There was a problem hiding this comment.
You are removing all the testing done via PAM.
In the end, this might be a complete rewrite of the sssd tests, rendering tests/sysauth/sssd.pm useless. A bit of background, those tests are a bit extensive but they were written by a developer that is long gone from the company, investing time in fixing or looking for an alternative to python-pam and rewrite the test suite is more expensive than switching to directly testing the service against the system (by means of directly using pam/passwd/getent)
You can adapt these tests to use directly openldap + sssd + pam via getent for instance to test the autentication.
But I'd propose a full module rewrite with a much simpler approach (like the pr mentioned in the ticket)
This test uses some "su" commands which use PAM but they run su as root to verify password. It seems incorrect. root can su any user without password. I did not try them manually. |
|
@tonyyuan1 sure thing :) Thanks! |
sssd test used python-pam, however it's unmantained and it was removed from package hub repo