Install shim and mokutil for JeOS aarch64 and RPi testing #12248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include _shim_ among pre-install packages for JeOS kvm aarch64 and RPi images. - Related ticket: [[aarch64][rpi] test fails in kdump_and_crash - handle missing package installation dialogue](https://progress.opensuse.org/issues/90770) - Verification runs:
mloviska
force-pushed
the
arm_kdump_inst_shim
branch
from
3cd54fe
to
ac2319f
Compare
mloviska
commented
Apr 8, 2021
| zypper_call('in mokutil') if is_jeos && get_var('UEFI') && !check_var('ARCH', 'aarch64'); | ||
|
|
||
| if (is_jeos && get_var('UEFI')) { | ||
| push @pkgs, is_aarch64 ? qw(mokutil shim) : qw(mokutil); |
There was a problem hiding this comment.
I haven't found a specific subroutine that would determine between rpi and aarch64 as shim should be included every except of rpi (https://build.suse.de/request/show/239027)
There was a problem hiding this comment.
Installing a pkg that is already installed doesn't break anything so that doesn't really matter anyway.
There was a problem hiding this comment.
Indeed, but as it should come pre-installed, this way we can possibly catch an unintentional drop of it from the kiwi template.
asdil12
approved these changes
Apr 8, 2021
| zypper_call('in mokutil') if is_jeos && get_var('UEFI') && !check_var('ARCH', 'aarch64'); | ||
|
|
||
| if (is_jeos && get_var('UEFI')) { | ||
| push @pkgs, is_aarch64 ? qw(mokutil shim) : qw(mokutil); |
There was a problem hiding this comment.
Installing a pkg that is already installed doesn't break anything so that doesn't really matter anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include shim among pre-install packages for JeOS kvm aarch64 and RPi images.