Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup_libyui and teardown_libyui #12298

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

sofiasyria
Copy link
Contributor

@sofiasyria sofiasyria commented Apr 14, 2021

@sofiasyria sofiasyria force-pushed the remove_setup branch 6 times, most recently from 0f870aa to ad91af4 Compare April 14, 2021 16:14
@sofiasyria sofiasyria changed the title [WIP] Remove setup_libyui and teardown_libyui Remove setup_libyui and teardown_libyui Apr 15, 2021
lib/bootloader_pvm.pm Outdated Show resolved Hide resolved
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just small change we can do to powerVM

Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! only minor thing I spot.

lib/YuiRestClient.pm Outdated Show resolved Hide resolved
lib/YuiRestClient.pm Outdated Show resolved Hide resolved
@sofiasyria sofiasyria force-pushed the remove_setup branch 4 times, most recently from 9107174 to ed55835 Compare April 19, 2021 13:40
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwx788 rwx788 merged commit 945a918 into os-autoinst:master Apr 20, 2021
@sofiasyria sofiasyria deleted the remove_setup branch May 17, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants