Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable soft fail record for 390 auth popup case #14118

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

coolgw
Copy link
Contributor

@coolgw coolgw commented Jan 27, 2022

Disable soft fail record for 390 auth popup case, base feedback on bsc#1192992, if version < 15sp4, the auth popup window is normal behavior.

@coolgw coolgw requested a review from dzedro January 27, 2022 09:40
@dzedro
Copy link
Contributor

dzedro commented Jan 27, 2022

You should pick < or > :)

@lemon-suse
Copy link
Contributor

As my understanding , the description should be updated from 'version <=15sp4' to 'version < 15sp4'

@dzedro
Copy link
Contributor

dzedro commented Jan 27, 2022

As my understanding , the description should be updated from 'version <=15sp4' to 'version < 15sp4'

Yes, please change the code to older versions than 15 SP4, this failure is still happening on older versions. is_sle('<15-sp4')
I don't understand how there is no soft fail in VR with is_sle('>=15-sp4')

https://openqa.suse.de/tests/8040928 15 SP2

@coolgw
Copy link
Contributor Author

coolgw commented Jan 27, 2022

As my understanding , the description should be updated from 'version <=15sp4' to 'version < 15sp4'

yes updated

@coolgw
Copy link
Contributor Author

coolgw commented Jan 28, 2022

As my understanding , the description should be updated from 'version <=15sp4' to 'version < 15sp4'

Yes, please change the code to older versions than 15 SP4, this failure is still happening on older versions. is_sle('<15-sp4') I don't understand how there is no soft fail in VR with is_sle('>=15-sp4')
[GW]: Base software feedback, if is_sle(>=15sp4), it should never popup auth windows,if is_sle(<15sp4) then auth window should pop up for first login.

https://openqa.suse.de/tests/8040928 15 SP2
[GW]: it's really strange why record_soft not print out

@coolgw coolgw force-pushed the 2022-01-27-remove-soft-issue branch from 4b5d209 to b35304c Compare January 28, 2022 10:27
@coolgw coolgw force-pushed the 2022-01-27-remove-soft-issue branch from b35304c to bbde48b Compare January 28, 2022 10:31
Copy link
Contributor

@dzedro dzedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's expected on older versions I would not use record_soft_fail on the counter, it will just spam the bug.

@coolgw coolgw added WIP Work in progress Ready Ready for review and removed WIP Work in progress labels Jan 28, 2022
@coolgw coolgw merged commit c6ea5f2 into os-autoinst:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants