Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Remove 'vim' out of installation console-tests #14201

Closed

Conversation

Zaoliang
Copy link
Contributor

@Zaoliang Zaoliang commented Feb 8, 2022

@okurz
Copy link
Member

okurz commented Feb 8, 2022

@DimStar77

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain in your git commit message how the coverage for vim is ensured if it's not included in the installation tests anymore. Do staging tests still execute the vim test module?

@Zaoliang
Copy link
Contributor Author

Zaoliang commented Feb 8, 2022

the idea is about put vim into extra_test_misc. vim should not be tested within installation in general. And I don't know why for staging this module is required.
At moment isotovideo failed, investigation...

@okurz
Copy link
Member

okurz commented Feb 8, 2022

the idea is about put vim into extra_test_misc. vim should not be tested within installation in general.

I know what the ticket says but the git commit messages should be self-contained to be able to understand the motivation of a change.

And I don't know why for staging this module is required

Well, if you don't know then don't change it. You change the schedule so it could be that the staging schedule does not include the module anymore.

@DimStar77
Copy link
Contributor

the idea is about put vim into extra_test_misc. vim should not be tested within installation in general. And I don't know why for staging this module is required. At moment isotovideo failed, investigation...

Staging, in general, is 'to ensure things do never break'; this implies that vim needs to be tested in staging; otherwise, we can't see side-effects impacting vim until they are checked in into a product, which in turn needlessly delays product/snapshot releases

@Martchus
Copy link
Contributor

Martchus commented Feb 9, 2022

Note that tests are likely failing because the test module is still referenced here:

@Zaoliang Zaoliang changed the title Remove 'vim' out of installation console-tests WIP Remove 'vim' out of installation console-tests Feb 9, 2022
@okurz
Copy link
Member

okurz commented Feb 9, 2022

Note that tests are likely failing because the test module is still referenced here:

IMHO as it should be. And that's also the discussion regarding staging tests

@Zaoliang
Copy link
Contributor Author

will find another way to handle this issue.

@Zaoliang Zaoliang closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants