-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Remove 'vim' out of installation console-tests #14201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain in your git commit message how the coverage for vim is ensured if it's not included in the installation tests anymore. Do staging tests still execute the vim test module?
the idea is about put vim into extra_test_misc. vim should not be tested within installation in general. And I don't know why for staging this module is required. |
70ec3b6
to
69929a4
Compare
I know what the ticket says but the git commit messages should be self-contained to be able to understand the motivation of a change.
Well, if you don't know then don't change it. You change the schedule so it could be that the staging schedule does not include the module anymore. |
69929a4
to
d08c32c
Compare
Staging, in general, is 'to ensure things do never break'; this implies that vim needs to be tested in staging; otherwise, we can't see side-effects impacting vim until they are checked in into a product, which in turn needlessly delays product/snapshot releases |
we should not test 'vim' within installation and add vim into extra_test_misc. see https://progress.opensuse.org/issues/95724 verification: https://openqa.opensuse.org/tests/2178941#step/vim http://10.162.30.85/tests/4590 (no vim)
d08c32c
to
25e08e9
Compare
Note that tests are likely failing because the test module is still referenced here:
|
IMHO as it should be. And that's also the discussion regarding staging tests |
will find another way to handle this issue. |
see https://progress.opensuse.org/issues/95724
verification:
https://openqa.opensuse.org/tests/2178941#step/vim