Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 'Permission settings' of atsec into openQA #14962

Merged
merged 1 commit into from May 27, 2022

Conversation

Amrysliu
Copy link
Contributor

@Amrysliu Amrysliu commented May 25, 2022

@Amrysliu Amrysliu force-pushed the integrate_permission_setting branch from 97568e9 to aaeb528 Compare May 25, 2022 08:31
@Amrysliu Amrysliu force-pushed the integrate_permission_setting branch from aaeb528 to 37d2975 Compare May 27, 2022 06:35
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

foreach my $file (split('\n', $output)) {
my $file_detail = script_output("readlink $file");
if ($file_detail !~ /(\/dev\/null|\/dev\/random)/) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to remove this blank line.

Copy link
Contributor

@RoyCai7 RoyCai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amrysliu Amrysliu merged commit 73209b4 into os-autoinst:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants