New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate 'Permission settings' of atsec into openQA #14962
Merged
Amrysliu
merged 1 commit into
os-autoinst:master
from
Amrysliu:integrate_permission_setting
May 27, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# SUSE's openQA tests | ||
# | ||
# Copyright 2022 SUSE LLC | ||
# SPDX-License-Identifier: FSFAP | ||
# | ||
# Summary: Run 'Permission settings of relevant configuration files' test case of ATSec test suite | ||
# Maintainer: xiaojing.liu <xiaojing.liu@suse.com> | ||
# Tags: poo#111518 | ||
|
||
use base 'consoletest'; | ||
use strict; | ||
use warnings; | ||
use testapi; | ||
use utils; | ||
|
||
sub run { | ||
my ($self) = shift; | ||
|
||
select_console 'root-console'; | ||
|
||
my $output = script_output('find -L /etc -perm -g+w,o+w'); | ||
|
||
# This test is to verify that important configuration files are protected | ||
# against access by unauthorized users. The result shows files that are softlinks | ||
# or the random device is allowed exception to the intial result expectation. | ||
foreach my $file (split('\n', $output)) { | ||
my $file_detail = script_output("readlink $file"); | ||
if ($file_detail !~ /(\/dev\/null|\/dev\/random)/) { | ||
|
||
# The file is not a softlink or doesn't link to expected device | ||
record_info($file, $file_detail, result => 'fail'); | ||
$self->result('fail'); | ||
} | ||
} | ||
} | ||
|
||
1; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to remove this blank line.