-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double confirm smt-mirror can pass #15261
base: master
Are you sure you want to change the base?
Conversation
8e82e2b
to
2428308
Compare
@rfan1 can you provide a VR where the error is properly detected?, I'm not sure about the regexp |
http://openqa.suse.de/t9207330 |
@rfan1 can you provide a failing case? |
http://openqa.suse.de/tests/9171525#step/system_prepare/5 But, I don't have any job can explain without "sync" cmd, the job failed one. however, I think it makes sense we issue "sync" command |
Let me try to set the disk size to 40GB and trigger a failed job then, hold on the merge process |
It's not really a regex, more of a string match. It may fail in the future but it will fail loudly and we can attempt a regex then. If @foursixnine doesn't still object I think we should merge. |
Due to bsc#1201738, enhance current logic to double check the log file to make sure smt-mirror passes without error
http://openqa.suse.de/tests/9208875#step/smt_server_install/57 BTW, I did some modification and executed the "df -h" command prior to log check, then we can check the disk full error easily |
@a-kpappas VR provided |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@rfan1 Do we want to continue working on this? |
@foursixnine
|
Due to bsc#1201738, enhance current logic to double check
the log file to make sure smt-mirror passes without error
http://openqa.suse.de/t9207330
http://openqa.suse.de/t9207331
http://openqa.suse.de/t9207332