Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double confirm smt-mirror can pass #15261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Jul 21, 2022

Due to bsc#1201738, enhance current logic to double check
the log file to make sure smt-mirror passes without error

@rfan1 rfan1 force-pushed the smt_mirror_result branch 2 times, most recently from 8e82e2b to 2428308 Compare July 25, 2022 01:12
@foursixnine
Copy link
Member

@rfan1 can you provide a VR where the error is properly detected?, I'm not sure about the regexp

@rfan1
Copy link
Contributor Author

rfan1 commented Jul 25, 2022

@rfan1 can you provide a VR where the error is properly detected?, I'm not sure about the regexp

http://openqa.suse.de/t9207330
http://openqa.suse.de/t9207331
http://openqa.suse.de/t9207332

@foursixnine
Copy link
Member

@rfan1 can you provide a failing case?

@rfan1
Copy link
Contributor Author

rfan1 commented Jul 25, 2022

@rfan1 can you provide a failing case?

http://openqa.suse.de/tests/9171525#step/system_prepare/5

But, I don't have any job can explain without "sync" cmd, the job failed one. however, I think it makes sense we issue "sync" command

@rfan1
Copy link
Contributor Author

rfan1 commented Jul 25, 2022

@rfan1 can you provide a failing case?

Let me try to set the disk size to 40GB and trigger a failed job then, hold on the merge process

@a-kpappas
Copy link
Contributor

It's not really a regex, more of a string match. It may fail in the future but it will fail loudly and we can attempt a regex then. If @foursixnine doesn't still object I think we should merge.

Due to bsc#1201738, enhance current logic to double check
the log file to make sure smt-mirror passes without error
@rfan1
Copy link
Contributor Author

rfan1 commented Jul 25, 2022

@rfan1 can you provide a failing case?

Let me try to set the disk size to 40GB and trigger a faild job then, hold on the merge process

http://openqa.suse.de/tests/9208875#step/smt_server_install/57

BTW, I did some modification and executed the "df -h" command prior to log check, then we can check the disk full error easily

@rfan1
Copy link
Contributor Author

rfan1 commented Jul 25, 2022

It's not really a regex, more of a string match. It may fail in the future but it will fail loudly and we can attempt a regex then. If @foursixnine doesn't still object I think we should merge.

@a-kpappas VR provided

@stale
Copy link

stale bot commented Oct 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If it's still needed, you can add labels WIP or notready to it

@stale stale bot added the stale Stale pull request, are to be deleted within 90 days label Oct 29, 2022
@foursixnine foursixnine added notready and removed stale Stale pull request, are to be deleted within 90 days labels Nov 11, 2022
@foursixnine
Copy link
Member

@rfan1 Do we want to continue working on this?

@rfan1
Copy link
Contributor Author

rfan1 commented Dec 6, 2022

@rfan1 Do we want to continue working on this?

@foursixnine
I would hold on this PR:

  1. the issue was not seen any more after increasing the disk size to 100gb.
  2. My codes are too strict to check the error messages due to bsc#1201738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants