Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DNS SRV records issue for samba test #15288

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Jul 28, 2022

As per poo#114718, join the Active Directory may fail sporadically
duo to occasional DNS resolve issue. so add more retries.

As per poo#114718, join the Active Directory may fail sporadically
duo to occasional DNS resolve issue. so add more retries.
@rfan1
Copy link
Contributor Author

rfan1 commented Jul 28, 2022

@martinsmarcelo Could you please help review my PR?

Copy link
Contributor

@michaelgrifalconi michaelgrifalconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinsmarcelo
Copy link
Contributor

LGTM, But I am not rights to approve.

@rfan1
Copy link
Contributor Author

rfan1 commented Jul 28, 2022

LGTM, But I am not rights to approve.

Anyway, thanks much for your kindly help!

@foursixnine foursixnine merged commit 66eb81c into os-autoinst:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants