New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run list-timers before shutdown #15294
Run list-timers before shutdown #15294
Conversation
@@ -13,6 +13,9 @@ use power_action_utils 'power_action'; | |||
use utils; | |||
|
|||
sub run { | |||
my $self = shift; | |||
select_console('root-console'); | |||
script_run('systemctl list-timers --all'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would recommend to replace this with $self->save_and_upload_log('systemctl list-timers --all', '/tmp/all_timers.log', {screenshot => 1});
. that will store a file in the Logs and Assets wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, upload won't work because shutdown
is run after cleanup_before_shutdown
that takes down the network. See
os-autoinst-distri-opensuse/tests/shutdown/cleanup_before_shutdown.pm
Lines 57 to 62 in 0385b0e
if ($network_status =~ /wicked/) { | |
systemctl 'stop network.service'; | |
systemctl 'stop wickedd.service'; | |
assert_script_run('ls /var/lib/wicked/'); | |
save_screenshot; | |
script_run('rm -f /var/lib/wicked/*.xml'); |
and https://openqa.suse.de/tests/9230015#step/shutdown/6
I guess it should be enough to print it since it's a rather small output and easy to read, but open to ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this breaks the test https://openqa.suse.de/tests/9239946#step/shutdown/2.
I would recommend to use https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/Utils/Systemd.pm#L58 instead of script_run
…timers Run list-timers before shutdown
…timers Run list-timers before shutdown
Run list-timers before shutdown and print the result to the console