Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would recommend to replace this with
$self->save_and_upload_log('systemctl list-timers --all', '/tmp/all_timers.log', {screenshot => 1});
. that will store a file in the Logs and Assets wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, upload won't work because
shutdown
is run aftercleanup_before_shutdown
that takes down the network. Seeos-autoinst-distri-opensuse/tests/shutdown/cleanup_before_shutdown.pm
Lines 57 to 62 in 0385b0e
and https://openqa.suse.de/tests/9230015#step/shutdown/6
I guess it should be enough to print it since it's a rather small output and easy to read, but open to ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this breaks the test https://openqa.suse.de/tests/9239946#step/shutdown/2.
I would recommend to use https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/Utils/Systemd.pm#L58 instead of
script_run