Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module to enable FIPS on transactional servers #16492

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jlausuch
Copy link
Contributor

@jlausuch jlausuch commented Feb 28, 2023

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

use version_utils qw(is_sle_micro);

sub run {
select_console 'root-console';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select_console 'root-console';
select_serial_terminal;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, due to transactional-update commands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They work with serial terminal just fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #16102

@jlausuch
Copy link
Contributor Author

@Vogtinator so, this is the error I encountered in MicroOS: https://openqa.opensuse.org/tests/3149442#step/enable_fips/25

@Vogtinator
Copy link
Member

Vogtinator commented Feb 28, 2023

@Vogtinator so, this is the error I encountered in MicroOS: https://openqa.opensuse.org/tests/3149442#step/enable_fips/25

Please reopen https://bugzilla.suse.com/show_bug.cgi?id=1198065 or file a new one, this is a severe product bug.

@jlausuch jlausuch merged commit a755e32 into os-autoinst:master Mar 1, 2023
jlausuch added a commit to jlausuch/os-autoinst-distri-opensuse that referenced this pull request Mar 1, 2023
New module to enable FIPS on transactional servers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants