Containers: retry on pulling image for test privileged mode #17909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilausuch
commented
Oct 4, 2023
•
ilausuch
commented
- Related ticket: https://progress.opensuse.org/issues/135518
- Verification run: http://openqa.suse.de/tests/12373112
ilausuch
force-pushed
the
improve_test_containers_privileged_2
branch
from
f58250c
to
4446cf0
Compare
grisu48
reviewed
Oct 4, 2023
tests/containers/privileged_mode.pm
Outdated
| @@ -25,6 +26,7 @@ sub run { | |||
| reset_container_network_if_needed($runtime); | |||
|
|
|||
| my $image = "registry.suse.com/bci/bci-base:latest"; | |||
| script_retry("$runtime pull $image", delay => 60, retry => 3); | |||
There was a problem hiding this comment.
Suggested change
| script_retry("$runtime pull $image", delay => 60, retry => 3); | |
| script_retry("$runtime pull $image", timeout => 300, delay => 120, retry => 3); |
The default timeout for pulling is 30 seconds, and that might be too low. Let's increase the default timeout.
ilausuch
force-pushed
the
improve_test_containers_privileged_2
branch
from
4446cf0
to
8254008
Compare
grisu48
approved these changes
Oct 4, 2023
|
Thanks. The code you changed works as expected and I would approve the change. |
|
I moved this approach to an other PR to unify solutions #17921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.