Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers: fix problems with privileged mode #17921

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Containers: fix problems with privileged mode #17921

merged 1 commit into from
Oct 17, 2023

Conversation

ilausuch
Copy link
Contributor

@ilausuch ilausuch commented Oct 5, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@ilausuch ilausuch force-pushed the fix_containers_privileged_problems branch from a7b5042 to f962a87 Compare October 5, 2023 09:45
@ilausuch ilausuch marked this pull request as ready for review October 5, 2023 10:37
@ilausuch
Copy link
Contributor Author

ilausuch commented Oct 5, 2023

Don't merge yet, more tests has to be done

@ilausuch ilausuch added the WIP Work in progress label Oct 5, 2023
@ilausuch ilausuch force-pushed the fix_containers_privileged_problems branch from f962a87 to 8202e7f Compare October 5, 2023 13:55
@ilausuch ilausuch removed the WIP Work in progress label Oct 5, 2023
@ilausuch ilausuch mentioned this pull request Oct 5, 2023
Closed
@ilausuch ilausuch force-pushed the fix_containers_privileged_problems branch from 8202e7f to 57d143f Compare October 5, 2023 14:33
grisu48
grisu48 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks ok, but the progress ticket is not yet resolved with this one.

For the PR itself: LGTM.

@ilausuch ilausuch merged commit f2b738a into os-autoinst:master Oct 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grisu48 grisu48 grisu48 approved these changes

@ricardobranco777 ricardobranco777 ricardobranco777 approved these changes

@pdostal pdostal Awaiting requested review from pdostal pdostal is a code owner

@jlausuch jlausuch Awaiting requested review from jlausuch jlausuch is a code owner

@mloviska mloviska Awaiting requested review from mloviska mloviska is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ilausuch @grisu48 @ricardobranco777