Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refreshment issue for iscsi_client #18372

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

hjluo
Copy link
Contributor

@hjluo hjluo commented Dec 26, 2023

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@lemon-suse
Copy link
Contributor

Increase timeout for send_key_util_needle_match seems work, since this is a sporadic issue, please run VR 10 times to verify.
Ex: for i in {1..10}; do openqa-clone-custom-git-refspec http://github.com/<github_user>/os-autoinst-distri-opensuse/tree/ https://openqa.suse.de/tests/<job_id> TEST=<test_suite_name>_$i _SKIP_POST_FAIL_HOOKS= ; done

1 similar comment
@lemon-suse
Copy link
Contributor

Increase timeout for send_key_util_needle_match seems work, since this is a sporadic issue, please run VR 10 times to verify.
Ex: for i in {1..10}; do openqa-clone-custom-git-refspec http://github.com/<github_user>/os-autoinst-distri-opensuse/tree/ https://openqa.suse.de/tests/<job_id> TEST=<test_suite_name>_$i _SKIP_POST_FAIL_HOOKS= ; done

@hjluo hjluo force-pushed the redress_iscsi branch 2 times, most recently from b25cea5 to 6054338 Compare December 27, 2023 07:46
@hjluo
Copy link
Contributor Author

hjluo commented Dec 27, 2023

Increase timeout for send_key_util_needle_match seems work, since this is a sporadic issue, please run VR 10 times to verify. Ex: for i in {1..10}; do openqa-clone-custom-git-refspec http://github.com/<github_user>/os-autoinst-distri-opensuse/tree/ https://openqa.suse.de/tests/<job_id> TEST=<test_suite_name>_$i _SKIP_POST_FAIL_HOOKS= ; done

I've tried but all of them failed. so this may not be a refresh issue. and I've clicked and can't find the Start in the dropdown menu. And now I've reverted it to
b1d3963, so can you please merge it first as AC1: revert? cause you'll be on vacation the next day.

@hjluo hjluo force-pushed the redress_iscsi branch 12 times, most recently from 6b49763 to 35da75e Compare January 3, 2024 06:58
@hjluo hjluo changed the title Fix refreshment issue for iscsi_client WIP:Fix refreshment issue for iscsi_client Jan 3, 2024
@hjluo hjluo force-pushed the redress_iscsi branch 6 times, most recently from 0194fa0 to e72e4ad Compare January 4, 2024 03:24
@hjluo hjluo changed the title WIP:Fix refreshment issue for iscsi_client Fix refreshment issue for iscsi_client Jan 4, 2024
@hjluo
Copy link
Contributor Author

hjluo commented Jan 4, 2024

Increase timeout for send_key_util_needle_match seems work, since this is a sporadic issue, please run VR 10 times to verify. Ex: for i in {1..10}; do openqa-clone-custom-git-refspec http://github.com/<github_user>/os-autoinst-distri-opensuse/tree/ https://openqa.suse.de/tests/<job_id> TEST=<test_suite_name>_$i _SKIP_POST_FAIL_HOOKS= ; done

test_result

@lemon-suse
Copy link
Contributor

Increase timeout for send_key_util_needle_match seems work, since this is a sporadic issue, please run VR 10 times to verify. Ex: for i in {1..10}; do openqa-clone-custom-git-refspec http://github.com/<github_user>/os-autoinst-distri-opensuse/tree/ https://openqa.suse.de/tests/<job_id> TEST=<test_suite_name>_$i _SKIP_POST_FAIL_HOOKS= ; done

test_result

So this test results 30/30 passed also proved this is a refreshment issue.

@lemon-suse lemon-suse merged commit ed38ce2 into os-autoinst:master Jan 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants