Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Implement module for Slowroll testing #18422

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[RFC] Implement module for Slowroll testing #18422

wants to merge 1 commit into from

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Jan 10, 2024 •
edited

Slowroll is Beta. Repos are provided in download.o.o for testing. This commit introduce a new module which adds those repos in the system. it should be used after the main installation. The update and staging repos are the most interesting to test.

[type description here, PLEASE, REMOVE THIS LINE, PLACEHOLDER, BEFORE SUBMITTING THIS PULL REQUEST]

@github-actions GitHub Actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@b10n1k b10n1k added the RFC Request for Comments label Jan 10, 2024
@Martchus Martchus mentioned this pull request Jan 10, 2024
Merged
okurz
okurz requested changes Jan 10, 2024
View reviewed changes
tests/update/slowroll_repos.pm Outdated
Comment on lines 21 to 24
assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh --disable http://cdn.opensuse.org/slowroll/repo/src-oss/ base-src-oss";
assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh --disable https://download.opensuse.org/debug/slowroll/repo/oss/ base-oss-debug";
assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh http://codecs.opensuse.org/openh264/openSUSE_Tumbleweed/ h264";
assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh -p 70 http://ftp.gwdg.de/pub/linux/misc/packman/suse/openSUSE_Slowroll/Essentials/ packmam";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simply leave those out until they are needed

tests/update/slowroll_repos.pm Outdated
sub run {
my $self = shift;
select_serial_terminal;
# select_console 'root-console';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

tests/update/slowroll_repos.pm Outdated
use serial_terminal 'select_serial_terminal';
use utils 'zypper_call';
sub run {
my $self = shift;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

tests/update/slowroll_repos.pm
use testapi;
use serial_terminal 'select_serial_terminal';
use utils 'zypper_call';
sub run {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sub run {
sub run {

tests/update/slowroll_repos.pm Outdated
@@ -0,0 +1,32 @@
# SUSE's openQA tests
#
# Copyright 2024 SUSE LLC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2024 SUSE LLC
# Copyright SUSE LLC

tests/update/slowroll_repos.pm
# SPDX-License-Identifier: FSFAP

# Summary: Add slowroll repos in the system
# Maintainer: Yiannis Bonatakis <ybonatakis@suse.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foursixnine IMHO this could/should be core-team, ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b10n1k Can you clarify? I don't see a change, or comment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the author i used myself. But this can change later when @foursixnine clarify the @okurz 's question

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, let's keep as is for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okurz indeed! @b10n1k I'm fine with this being en qe-core, I think we can somehow merge the code, but since Yogesh left, we haven't been able to help here again.

lib/main_common.pm Outdated
@@ -2820,6 +2820,8 @@ sub load_system_update_tests {
}
else {
loadtest "update/zypper_clear_repos";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@b10n1k
Implement module for Slowroll testing
09755b9 
Slowroll is Beta. Repos are provided in download.o.o for testing. This commit
introduce a new module which adds those repos in the system. it should be used
after the main installation. The update and staging repos are the most
interesting to test.

Signed-off-by: Ioannis Bonatakis <ybonatakis@suse.com>
okurz
okurz requested changes Jan 17, 2024
View reviewed changes
tests/update/slowroll_repos.pm
# SPDX-License-Identifier: FSFAP

# Summary: Add slowroll repos in the system
# Maintainer: Yiannis Bonatakis <ybonatakis@suse.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, let's keep as is for now

tests/update/slowroll_repos.pm
sub run {
select_serial_terminal;
assert_script_run "rm /etc/zypp/repos.d/*";
assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh http://cdn.opensuse.org/slowroll/repo/oss/ base-oss";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now those repos as discussed in a ticket (or was it jitsi) are wrong as they should come from openQA for the to be tested state, not the released repos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a side question, why a new test module, when we could use the same or rehuse the same from leap?

okurz
okurz requested changes Jan 27, 2024
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole change is not correct and should not be merged. Repos must be added by openQA same as for e.g. Tumbleweed and Leap

@foursixnine
Copy link
Member

@b10n1k let us pick this next week instead

@b10n1k b10n1k marked this pull request as draft January 29, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foursixnine foursixnine foursixnine left review comments

@kalikiana kalikiana kalikiana left review comments

@okurz okurz okurz requested changes

Assignees
No one assigned
Labels
RFC Request for Comments
Projects
None yet
Milestone
No milestone
4 participants
@b10n1k @foursixnine @kalikiana @okurz