Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Implement module for Slowroll testing #18422

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[RFC] Implement module for Slowroll testing #18422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/main_common.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2820,6 +2820,7 @@ sub load_system_update_tests {
}
else {
loadtest "update/zypper_clear_repos";
loadtest "update/slowroll_repos" if check_var('VERSION', 'Slowroll');
set_var('CLEAR_REPOS', 1);
}
}
Expand Down
27 changes: 27 additions & 0 deletions tests/update/slowroll_repos.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# SUSE's openQA tests
#
# Copyright SUSE LLC
# SPDX-License-Identifier: FSFAP

# Summary: Add slowroll repos in the system
# Maintainer: Yiannis Bonatakis <ybonatakis@suse.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foursixnine IMHO this could/should be core-team, ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b10n1k Can you clarify? I don't see a change, or comment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the author i used myself. But this can change later when @foursixnine clarify the @okurz 's question

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, let's keep as is for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okurz indeed! @b10n1k I'm fine with this being en qe-core, I think we can somehow merge the code, but since Yogesh left, we haven't been able to help here again.


use Mojo::Base 'opensusebasetest';
use testapi;
use serial_terminal 'select_serial_terminal';

sub run {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sub run {
sub run {

select_serial_terminal;
assert_script_run "rm /etc/zypp/repos.d/*";
assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh http://cdn.opensuse.org/slowroll/repo/oss/ base-oss";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now those repos as discussed in a ticket (or was it jitsi) are wrong as they should come from openQA for the to be tested state, not the released repos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a side question, why a new test module, when we could use the same or rehuse the same from leap?

assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh http://cdn.opensuse.org/slowroll/repo/non-oss/ base-non-oss";
assert_script_run "zypper -n --gpg-auto-import-keys ar --refresh -p 80 http://cdn.opensuse.org/update/slowroll/repo/oss/ update";

assert_script_run "zypper -n --gpg-auto-import-keys dup";
}

sub test_flags {
return {fatal => 1};
}

1;