Use ay profile for multipath installation #18962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzedro
commented
Mar 26, 2024
dzedro
commented
- Related ticket: https://progress.opensuse.org/issues/126089
- Verification run: https://openqa.suse.de/tests/overview?build=jpupava_mpath&distri=sle
dzedro
added
Ready
rfan1
reviewed
Mar 27, 2024
Comment on lines
+397
to
+399
| % if ($check_var->('MULTIPATH', '1')) { | ||
| <device>/dev/mapper/0QEMU_QEMU_HARDDISK_hd0</device> | ||
| % } |
There was a problem hiding this comment.
One minor comment here, if we don't use these hardcode /dev/mapper/0QEMU_QEMU_HARDDISK_hd0, can we pass the job? ：）
There was a problem hiding this comment.
Not on SLE 12 https://dzedro.suse.cz/tests/819,
but I removed it on SLE 15, had issue on 15-SP2 which was at the end something else and left it there, it's not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.