Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ay profile for multipath installation #18962

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Use ay profile for multipath installation #18962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
085ce73
Extend installation ay profile with multipath
dzedro Mar 22, 2024
11b7540
Add check to test multipath
dzedro Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions data/autoyast_qam/12-common_base_installation.xml.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,11 @@
<accept_non_trusted_gpg_key config:type="boolean">true</accept_non_trusted_gpg_key>
<import_gpg_key config:type="boolean">true</import_gpg_key>
</signature-handling>
% if ($check_var->('MULTIPATH', '1')) {
<storage config:type="map">
<start_multipath config:type="boolean">true</start_multipath>
</storage>
% }
</general>
% if ($check_var->('ARCH', 'aarch64')) {
<partitioning config:type="list">
Expand Down Expand Up @@ -389,6 +394,9 @@
<pesize/>
<type config:type="symbol">CT_DISK</type>
% }
% if ($check_var->('MULTIPATH', '1')) {
<device>/dev/mapper/0QEMU_QEMU_HARDDISK_hd0</device>
% }
Comment on lines +397 to +399
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment here, if we don't use these hardcode /dev/mapper/0QEMU_QEMU_HARDDISK_hd0, can we pass the job? ：）

Copy link
Contributor Author

@dzedro dzedro Mar 27, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not on SLE 12 https://dzedro.suse.cz/tests/819,
but I removed it on SLE 15, had issue on 15-SP2 which was at the end something else and left it there, it's not needed.

<use>all</use>
</drive>
</partitioning>
Expand Down Expand Up @@ -461,6 +469,11 @@
<pattern><%= $pattern %></pattern>
% }
</patterns>
% if ($check_var->('MULTIPATH', '1')) {
<packages config:type="list">
<package>multipath-tools</package>
</packages>
% }
</software>
<services-manager>
% if ($check_var->('DESKTOP', 'gnome')) {
Expand All @@ -473,6 +486,9 @@
<disable config:type="list"/>
<enable config:type="list">
<service>sshd</service>
% if ($check_var->('MULTIPATH', '1')) {
<service>multipathd</service>
% }
</enable>
</services>
</services-manager>
Expand Down
13 changes: 12 additions & 1 deletion data/autoyast_qam/15-common_base_installation.xml.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,14 @@
<accept_non_trusted_gpg_key config:type="boolean">true</accept_non_trusted_gpg_key>
<import_gpg_key config:type="boolean">true</import_gpg_key>
</signature-handling>
% if ($check_var->('MULTIPATH', '1')) {
<storage>
<start_multipath config:type="boolean">true</start_multipath>
</storage>
% }
</general>
<partitioning config:type="list">
<drive>
<drive>
<initialize config:type="boolean">true</initialize>
<use>all</use>
</drive>
Expand Down Expand Up @@ -354,6 +359,9 @@
% }
<package>openssh</package>
<package>firewalld</package>
% if ($check_var->('MULTIPATH', '1')) {
<package>multipath-tools</package>
% }
</packages>
% }
<patterns config:type="list">
Expand All @@ -373,6 +381,9 @@
<disable config:type="list"/>
<enable config:type="list">
<service>sshd</service>
% if ($check_var->('MULTIPATH', '1')) {
<service>multipathd</service>
% }
</enable>
</services>
</services-manager>
Expand Down
1 change: 1 addition & 0 deletions tests/console/kdump_and_crash.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use serial_terminal 'select_serial_terminal';

sub run {
select_serial_terminal;
validate_script_output('lsblk', sub { m/mpath/ }) if get_var('MULTIPATH');
if (kdump_utils::configure_service(test_type => 'function') == 16) {
record_info 'Not supported', 'Kdump is not supported in a PV DomU';
return;
Expand Down