zKVM: Add capability for Upgrades and booting images #2196
Conversation
|
requires: os-autoinst/os-autoinst#661 Verification for Upgrade: http://10.160.5.109/tests/4336 may need some refactoring, feedback welcome - therefor the notready label -> @mnowaksuse @coolo |
Soulofdestiny
force-pushed
the
feature/zkvm_boot_existing
branch
from
d55ffe2
to
728cc80
Compare
|
|
||
| # temporary use of hardcoded '+4' to workaround messed up network setup on z/KVM | ||
| my $vtap = $svirt->instance + 4; | ||
| my $repo = "ftp://openqa.suse.de/" . get_var('REPO_0'); |
There was a problem hiding this comment.
I don't think it is a good idea to hardcode this here
There was a problem hiding this comment.
but use what instead? I'm not aware of any variable providing this
There was a problem hiding this comment.
Maybe using a jobsetting: e.g get_var("SUSEMIRROR") which is used in few places, might be wise to keep using that one... but i'm guessing in most cases it is not present but only http|https is supported (According to bmwqemu)
There was a problem hiding this comment.
ok, it's only moved here so fine for this PR but
@Soulofdestiny please replace the hardcoded values in all test files accordingly. I am awaiting your PR then :-)
There was a problem hiding this comment.
well, found one which should be always set...
| @@ -21,6 +21,12 @@ sub run() { | |||
| record_soft_failure 'workaround missing release notes'; | |||
| return; | |||
| } | |||
|
|
|||
| # workaround for bsc#1014178 | |||
| if (check_screen('zfcp-popup')) { | |||
There was a problem hiding this comment.
this will waste 30 seconds in every run unless the screen is shown. Either make this a check_screen …, 0; or use a multi-tag assert_screen in a later step
|
|
||
| # clean up on s390pb | ||
| type_string("rm -f /var/lib/libvirt/images/$name && echo 'OK'\n"); | ||
| assert_screen('svirt-image-cleaned-up', 30); |
| @@ -58,6 +58,10 @@ sub extract_assets { | |||
|
|
|||
| upload_asset("/var/lib/libvirt/images/$name", 1, 1); | |||
| assert_screen('svirt-asset-upload-hdd-image-uploaded', 1000); | |||
|
|
|||
| # clean up on s390pb | |||
| type_string("rm -f /var/lib/libvirt/images/$name && echo 'OK'\n"); | |||
There was a problem hiding this comment.
why not just
assert_script_run "rm -f /var/lib/libvirt/images/$name";There was a problem hiding this comment.
generally agreed, just want to stick to the previous ones to keep it consistent
There was a problem hiding this comment.
this code does not run on the SUT but on the hypervisor, so it has no access to the serial console of the SUT.
We have limited space on s390pb, so we can't store every single image there Let's remove it after it got uploaded to the worker
Soulofdestiny
force-pushed
the
feature/zkvm_boot_existing
branch
from
728cc80
to
e831d61
Compare
| } | ||
| else { | ||
| loadtest "installation/bootloader_svirt"; | ||
| } |
There was a problem hiding this comment.
that's not how it should be, please open a progress issue to improve the two bootloader implementations.
DRY. You are calling the same code multiple times, please extract method.
There was a problem hiding this comment.
|
|
||
| # temporary use of hardcoded '+4' to workaround messed up network setup on z/KVM | ||
| my $vtap = $svirt->instance + 4; | ||
| my $repo = "ftp://openqa.suse.de/" . get_var('REPO_0'); |
There was a problem hiding this comment.
ok, it's only moved here so fine for this PR but
@Soulofdestiny please replace the hardcoded values in all test files accordingly. I am awaiting your PR then :-)
No description provided.