Add 'nologin' parameter for wait_boot #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows boot to graphical DM without login to it. Usable for tests like gnomecase/change_password Fixes poo#29066
|
I will merge as it blocks us for long enough. But please for next time: please don't use no parameters without no please, it's not confusing without no. Just describe what is done instead. wait_before_login => 1 is way more description than nologin |
okurz
reviewed
Dec 12, 2017
| @@ -310,6 +310,7 @@ sub wait_boot { | |||
| my $textmode = $args{textmode}; | |||
| my $ready_time = $args{ready_time} // 200; | |||
| my $in_grub = $args{in_grub} // 0; | |||
| my $nologin = $args{nologin}; | |||
There was a problem hiding this comment.
That parameter is not described in the doc-string. That would be appreciated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows boot to graphical DM without login to it.
Usable for tests like gnomecase/change_password
Fixes poo#29066