Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for java 10, since the release date was added behind the ver… #4162

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Conversation

DimStar77
Copy link
Contributor

@DimStar77 DimStar77 commented Jan 8, 2018

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused here. If this is a bug, shouldn't we add soft failure here? And do we run this test anywhere, where java 9 is active version still?

@DimStar77
Copy link
Contributor Author

It was filed as a bug as it was not clear if java exposes an invalid version or if the test needs to be updated - turned out, the test needed updating

As for java 9: yes; TW contains Java 8, Java 9 and Java 10, and the test runs all three versions in sequence, see : https://openqa.opensuse.org/tests/576405#step/java/14
( you see the various versions of java tested in sequence)

@drpaneas
Copy link
Contributor

drpaneas commented Jan 9, 2018

the test is now passing

java-10-openjdk:
update-alternatives: using /usr/lib64/jvm/jre-10-openjdk/bin/java to provide /usr/bin/java (java) in manual mode
update-alternatives: using /usr/lib64/jvm/java-10-openjdk/bin/javac to provide /usr/bin/javac (javac) in manual mode
dot_verion=10-openjdk
dot_version_short=10
check linked java version: OK -> linked java is: 10-internal and language level is 10
dot_verion=10-openjdk
dot_version_short=10
check linked javac version: PASS
Java Compiler: PASS
Java runtime: PASS

LGTM

@rwx788
Copy link
Member

rwx788 commented Jan 9, 2018

@DimStar77 could you please shorten commit and PR title, e.g. "Fix java 10 version number parsing" and put current sentence to the description? I guess we also can resolve the bug. Thanks!

JDK started adding the release date into the -version output, but according to the JDK documentation,
version string is supposedly statically built, with '$3 defined to be the 'version' (between quotes)

Addresses https://bugzilla.opensuse.org/show_bug.cgi?id=1074036
@DimStar77
Copy link
Contributor Author

@rwx788 PR updated; once merged, I'll close the bug as fixed

@rwx788 rwx788 merged commit 76e5894 into os-autoinst:master Jan 9, 2018
@DimStar77 DimStar77 deleted the java10 branch January 9, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants