Enable partition_filesystem for textmode #4172
Conversation
|
@SergioAtSUSE here we go |
|
Do we really have to change the PR template to "If you can still read this dummy text the PR never replaced it and is stupid" ;) |
|
Verification runs for Tumbleweed
Verification runs for Leap 42.3
Verification for SLE 15
Verification for SLE 12-SP3
|
DrMullings
force-pushed
the
txt_partition_fs
branch
from
69403dc
to
fcc8306
Compare
SergioAtSUSE
force-pushed
the
txt_partition_fs
branch
3 times, most recently
from
6d1160a
to
33b7707
Compare
|
|
I don't know why you have created needles with excluded areas, for me, these needles only work when I remove the excluded area. (See gl/needles-sles#bea83666) |
|
On s390x there is a bug on svirt backend that doesn't allow to send the 'home' key on textmode. https://progress.opensuse.org/issues/30409 But this will not brake any existing test, since there is no textmode test for module partitioning_filesystem. All the other OS and archs were properly verified on local runs. Except ppc. |
SergioAtSUSE
force-pushed
the
txt_partition_fs
branch
from
89998fb
to
c0d9009
Compare
SergioAtSUSE
changed the title
| assert_and_click 'edit-proposal-settings'; | ||
| # open the partinioner | ||
| assert_screen 'edit-proposal-settings'; | ||
| wait_screen_change { send_key(is_storage_ng() ? 'alt-g' : 'alt-d') }; |
There was a problem hiding this comment.
Please, use $cmd{guidedsetup} here
SergioAtSUSE
force-pushed
the
txt_partition_fs
branch
from
c0d9009
to
864aaa3
Compare
|
Use of $cmd also verified: http://copland.arch.suse.de/tests/214#step/partitioning_filesystem/7 |
| @@ -20,9 +20,11 @@ use partition_setup 'unselect_xen_pv_cdrom'; | |||
| sub run { | |||
|
|
|||
| my $fs = get_var('FILESYSTEM'); | |||
| $cmd{guidedsetup} = 'alt-g' if (is_storage_ng()); | |||
There was a problem hiding this comment.
We don't need this, as we have it here.
Adapted the partition_filesystem module for textmode FILESYSTEM setting is required to trigger it.
SergioAtSUSE
force-pushed
the
txt_partition_fs
branch
from
864aaa3
to
3fef4f4
Compare
|
https://openqa.opensuse.org/tests/584220#step/partitioning_filesystem/3 a fallout from here? Missing needles? |
|
needles PR for openSUSE merged, the one for SLE needs to be reworked @rwx788 next time be more careful @SergioAtSUSE @DrMullings please ensure the openSUSE tests will run fine again |
|
No need for revert - I created needles that made the partition_filesystem test pass on TW; At first it was not exactly clear what areas ware to be looked at - needed to first understand the test and its intentiona. All good now |
|
maybe somenody can verify that the two needles created and used on https://openqa.opensuse.org/tests/584407 make sense (root_selected and ext4 selected) |
|
My bad, will merge needles first next time. |
Adapted the partition_filesystem module for textmode
FILESYSTEM setting is required to trigger it.
-12/3