LTP: Disable reboot after install to avoid snapshot #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boot_ltp is marked as a milestone so that we can revert to it during normal testing. It is also ran after install_ltp as a sanity check to make sure the system boots into a clean state after installing the LTP (because a lot of tests depend on it, so we don't want every test to fail in boot_ltp). However the qcow2 image published by install_ltp has become very large since boot_ltp was marked as a milestone. We don't want to remove boot_ltp's milstone, so instead we can remove boot_ltp from the install_module. At least temporarily. Also snapshots currently fail a lot, especially for VMs with larger amounts of RAM in use.
asmorodskyi
reviewed
Jan 25, 2018
| @@ -113,7 +113,7 @@ sub maybe_load_kernel_tests { | |||
| loadtest 'update_kernel'; | |||
| } | |||
| loadtest 'install_ltp'; | |||
| loadtest 'boot_ltp'; | |||
| #loadtest 'boot_ltp'; | |||
There was a problem hiding this comment.
better delete line if you don't need it, and if you will need it later this is why we using git :)
There was a problem hiding this comment.
Yes, I will probably remove it in the next round of fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boot_ltp is marked as a milestone so that we can revert to it during normal
testing. It is also ran after install_ltp as a sanity check to make sure the
system boots into a clean state after installing the LTP (because a lot of
tests depend on it, so we don't want every test to fail in boot_ltp). However
the qcow2 image published by install_ltp has become very large since boot_ltp
was marked as a milestone.
We don't want to remove boot_ltp's milstone, so instead we can remove boot_ltp
from the install_module. At least temporarily.
Also snapshots currently fail a lot, especially for VMs with larger amounts of
RAM in use.