Skip 2nd&3rd runs when all selecting patterns in sle15 #4632
Conversation
jknphy
changed the title
jknphy
force-pushed
the
fix_select_all_patterns
branch
from
7ff9292
to
79346e8
Compare
jknphy
changed the title
jknphy
changed the title
| $self->gotopatterns; | ||
| $self->package_action('unblock'); | ||
| if (is_sle('15+') and check_var('PATTERNS', 'all')) { | ||
| record_soft_failure "bsc#1084064 - Cloud patterns conflicts"; # skip second & third runs |
There was a problem hiding this comment.
Would it somehow be possible to actually detect the situation? Here we will not see when the bug got fixed and the soft failure will be preserved, right?
jknphy
force-pushed
the
fix_select_all_patterns
branch
from
79346e8
to
45502c5
Compare
jknphy
changed the title
jknphy
force-pushed
the
fix_select_all_patterns
branch
2 times, most recently
from
4456ed9
to
7801e71
Compare
jknphy
changed the title
jknphy
force-pushed
the
fix_select_all_patterns
branch
from
7801e71
to
b28caa5
Compare
| @@ -84,6 +84,7 @@ sub workaround_dependency_issues { | |||
| sleep 2; | |||
| } | |||
| } | |||
| return 1; | |||
There was a problem hiding this comment.
can you comment on this change? What does it change/fix?
There was a problem hiding this comment.
if the function detects the dependency issue returns 1, so we can know that at least there was a conflict. Otherwise returns undef (that is was originally was returning).
| $self->workaround_dependency_issues; | ||
| # stick to the default patterns | ||
| $dep_issue = $self->workaround_dependency_issues || $dep_issue; # check if at least 1 dep. issue was displayed | ||
| # stick to the default patterns |
There was a problem hiding this comment.
better to split the comments from the code, i.e. move the comment in the previous above the code and not next to it
There was a problem hiding this comment.
tidy put together, yes, better on the top.
jknphy
force-pushed
the
fix_select_all_patterns
branch
from
b28caa5
to
c1ed9ff
Compare
|
I didn't know that. I will remember to write a comment in these cases. Thx :) |
While this bug/future requested feature related with conflicts among cloud patterns is fixed/implemented we can skip from the test 2nd and 3rd run (which I was not able to figure out what is its purpose for old products) but at least in this test we will select all patterns not conflicting atm. Added checking if there is some conflicting package, we flag it and then we skip next runs.