zypper_lifecycle: Ensure product name is only matched in its own line #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent matching in case on our serialdev we have a getty prompt interfering with the message "Welcome to SUSE Linux Enterprise …". see https://openqa.suse.de/tests/1642305#step/zypper_lifecycle/34 Related progress issue: https://progress.opensuse.org/issues/32761
|
@lemon-suse @dehai would be able to test this? |
|
Oliver, I verified your fix in perl script on my local machine( just with the welcome string as input to check whether the fix work or not). Besides, I agree to workaround this issue in test code although it caused by the wrong output of script_output. |
|
Sure, this will work but unfortunately do not trust my code not enough to merge it without an openQA verification run which I can not currently provide. |
|
Thanks to @lemon-suse for local verification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent matching in case on our serialdev we have a getty prompt interfering
with the message "Welcome to SUSE Linux Enterprise …".
see https://openqa.suse.de/tests/1642305#step/zypper_lifecycle/34
Related progress issue: https://progress.opensuse.org/issues/32761