Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable repos when install medium are dvds #6847

Merged
merged 1 commit into from Feb 20, 2019

Conversation

foursixnine
Copy link
Member

@foursixnine foursixnine commented Feb 20, 2019

@@ -18,6 +19,12 @@ use utils 'zypper_call';

sub run {
select_console 'root-console';

# see FATE#325541
zypper_call 'mr -e -l'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the third place we got it =(. Would you be the one who can put single implementation?
tests/autoyast/repos.pm
tests/sles4sap/patterns.pm
are the other 2 places...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwx788 indeed, thought about creating a follow-up ticket to do the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way or another, feel free to merge this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'll merge for now, pick the followup later in the sprint

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's refactor later on

@rwx788 rwx788 merged commit db9c199 into os-autoinst:master Feb 20, 2019
@nilxam
Copy link
Member

nilxam commented Feb 20, 2019

Test died: Undefined subroutine &zypper_ref::is_sle called at /var/lib/openqa/cache/openqa1-opensuse/tests/opensuse/tests/console/zypper_ref.pm line 24.

@rwx788
Copy link
Member

rwx788 commented Feb 20, 2019

Ouch. @foursixnine will you provide patch.

@foursixnine
Copy link
Member Author

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants