Remove code duplication for enabling DVD repositories #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foursixnine
force-pushed
the
cleanup-abit
branch
2 times, most recently
from
86ae8dc
to
8f92ee5
Compare
foursixnine
force-pushed
the
cleanup-abit
branch
from
8f92ee5
to
b668d6c
Compare
foursixnine
commented
Apr 10, 2019
| # see FATE#325541 | ||
| zypper_call 'mr -e -l' if get_var('AUTOYAST') | ||
| || is_sle('15+') and get_var('ISO_1', '') =~ /SLE-.*-Packages-.*\.iso/; | ||
| zypper_call 'ref'; |
There was a problem hiding this comment.
I take that "Enable dvd's" it's a step on it's own, and that includes the ref. Should we rename or repurpose the zypper_ref?
There was a problem hiding this comment.
Actually you can skip AUTOYAST variable check, as it also has ISO_1 (all packages DVD mounted).
rwx788
approved these changes
Apr 10, 2019
foursixnine
force-pushed
the
cleanup-abit
branch
from
b668d6c
to
265afea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #6847 @rwx788 and I noticed that there's some code duplicated, so this is the follow up.
As an idea I might create later Lib::Utils::Zypper and move zypper related functions there, in an attempt to clean up a bit the lib/utils.pm