Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle command failure in script_run_interactive #6978

Merged
merged 1 commit into from Mar 12, 2019
Merged

Handle command failure in script_run_interactive #6978

merged 1 commit into from Mar 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2019

script_run_interactive can not handle failure situation when running the command. Fix it by involving return value inside the typescript.

Also make it support running the command only - by passing undef at the second parameter. Change aa_genprof to adopt this method.

lib/utils.pm Show resolved Hide resolved
script_run_interactive can not handle failure situation when running
the command. Fix it by involving return value inside the typescript.

Also make it support running the command only - by passing undef at
the second parameter. Change aa_genprof to adopt this method.

Fix poo#48521
@lemon-suse lemon-suse merged commit 3fb141f into os-autoinst:master Mar 12, 2019
@ghost ghost deleted the fix_script_run_interactive branch March 12, 2019 07:20
@ostruzina
Copy link
Contributor

Hello @wnereiz, I believe that these changes may have broken the usr_lib_dovecot_imap module in maintenance tests, e.g. https://openqa.suse.de/tests/2536919#step/usr_lib_dovecot_imap/52

When the logout is completed, there is a return code 1 and the test dies, even though the action was actually completed successfully. Could you take a look?

@ghost
Copy link
Author

ghost commented Mar 13, 2019

@ostruzina I saw the failure. It is basically the issue of case "usr_lib_dovecot_imap" (or telnet), script_run_interactive can do nothing about it.

Telnet return 1 even everything in process handled successfully. With some research, we found sending ^] to terminate telnet maybe a workaround. We will modify the case later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants