Replace start_firefox as x11_start_program for firefox_nss

[jouyingbin]

1. To avoid start_firefox cause the URL render error randomly (poo#47018)
2. Provide match_timeout => 360
3. Add Turn off screensaver before launching firefox

• Randomly Error : https://openqa.suse.de/tests/2549658#step/firefox_nss/6

• Related ticket: https://progress.opensuse.org/issues/47018

• Needles: N/A

• Verification run: http://147.2.217.68/tests/29 or http://10.163.10.37/tests/29

[lilyeyes]

LGTM. Thanks for the fix.

[dzedro]

@jouyingbin I have doubts that longer timeout will help, I don't have problem with waiting longer, it's still better to see timeout page in firefox than openqa failure because of short timeout. But if you check the failure last needle failed with black screen, I guess screensaver/blankscreen was activated.

[dzedro]

Timeout in start_firefox can be increased too, but it won't help when screensaver get activated in between

[jouyingbin]

@dzedro Thanks for reviewing,
We met the problem before randomly, somemtimes it was passed. So I don't know if it is the timeout is too short. There are some different testing results.
https://openqa.suse.de/tests/2536224#step/firefox_nss/8 [Fail]
https://openqa.suse.de/tests/2510354#step/firefox_nss/5 [Fail]
https://openqa.suse.de/tests/2494389#step/firefox_nss/5 [Passed]

Do you mean that we still use start_firefox with longer timeout?

[dzedro]

@jouyingbin yes, I think with firefox is longer timeout generally not bad, it's better to see firefox error page than openqa timeout failure, then you have some clue if page timed out or there was another problem, but mostly it's network problem.

[dzedro]

With timeout above 300, I think it's default screensaver timeout, screensaver will have to be turned off or changed timeout

[jouyingbin]

@dzedro Thanks for your suggestions, as in my local system, it takes over 300, thus I set it as 360 for my testing, it really depends on the different network environment, I think we can merge this one and adjust screensaver in the future, thanks.

[jouyingbin]

And I also added to turn off gnome screensaver before launching the firefox. [Done]

[lilyeyes]

I think the "poo#47018" in "Tag" is not the original poo when this test case was added.
And, add another Tag tc#$testcase_number is better if it exists.

[jouyingbin]

Actually, the tc# is not that mandatory for the openQA test case, because the case is slightly different from our original tc#. Furthermore, the test case number will be outdated in the next product SPx release. Thanks.

[lilyeyes]

OK! thanks for the explanation.

[ghost]

LGTM