Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace start_firefox as x11_start_program for firefox_nss #7102

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Replace start_firefox as x11_start_program for firefox_nss #7102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/fips/mozilla_nss/firefox_nss.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SUSE's openQA tests - FIPS tests
#
# Copyright © 2016-2018 SUSE LLC
# Copyright © 2016-2019 SUSE LLC
#
# Copying and distribution of this file, with or without modification,
# are permitted in any medium without royalty provided the copyright
Expand All @@ -12,11 +12,13 @@
# Summary: FIPS mozilla-nss test for firefox
# Maintainer: mitiao <mitiao@gmail.com>,
# wnereiz <wnereiz@fsf.member.org>
# Tag: poo#47018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "poo#47018" in "Tag" is not the original poo when this test case was added.
And, add another Tag tc#$testcase_number is better if it exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the tc# is not that mandatory for the openQA test case, because the case is slightly different from our original tc#. Furthermore, the test case number will be outdated in the next product SPx release. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! thanks for the explanation.


use base "x11test";
use strict;
use warnings;
use testapi;
use x11utils 'turn_off_gnome_screensaver';

sub quit_firefox {
send_key "alt-f4";
Expand All @@ -34,7 +36,9 @@ sub run {
# - at least one non-alphabet-non-number character (like: @-.=%)
my $fips_password = 'openqa@SUSE';

$self->start_firefox;
# Turn off screensaver before launch firefox in order to avoid the screensaver block
turn_off_gnome_screensaver if check_var('DESKTOP', 'gnome');
x11_start_program('firefox https://html5test.opensuse.org', target_match => 'firefox-html-test', match_timeout => 360);

# Firfox Preferences
send_key "alt-e";
Expand Down