wicked: Upload files via serial console #7565
Conversation
tests/wicked/before_test.pm
Outdated
|
|
||
| sub run { | ||
| my ($self, $ctx) = @_; | ||
| $self->select_serial_terminal; | ||
| add_serial_console('hvc1'); |
There was a problem hiding this comment.
We could call it somewhere generic with a condition of BACKEND==qemu and VIRTIO_CONSOLE_NUM>1 and is SLES. But I didn't found a good place.
|
Impressive job! Just a few small modifications and good to go. |
cfconrad
force-pushed
the
wicked_offline_upload
branch
3 times, most recently
from
83c500d
to
f1bdebd
Compare
cfconrad
force-pushed
the
wicked_offline_upload
branch
2 times, most recently
from
611eea4
to
825ad64
Compare
cfconrad
changed the title
|
VR with latest os-autoinst: http://cfconrad-vm.qa.suse.de/tests/4941#step/t08_setup_second_card/127 The testsuite needs to add the |
|
This http://cfconrad-vm.qa.suse.de/tests/4945/file/serial_terminal.txt is how it looks if the job was run with |
cfconrad
force-pushed
the
wicked_offline_upload
branch
from
4ae12cf
to
462260c
Compare
|
Sandbox VR with download and upload http://cfconrad-vm.qa.suse.de/tests/4955 |
|
@rwx788 @okurz @coolgw @foursixnine and others, please review this new option to transfer files from/to OpenQA VM via serial. Useful when there is no network configured in the VM (i.e. networking tests). |
|
LGTM beside to minor comments which I did before |
cfconrad
force-pushed
the
wicked_offline_upload
branch
from
462260c
to
f704c36
Compare
There was a problem hiding this comment.
Looks really good!
I recently came across the qemu -drive file=fat:rw:some/directory ... which would expose a drive on the qemu guest. (But has some drawbacks regarding the filesystem + needing to mount the disk et al)... Not to question your idea, but did you check that one also?
lib/wickedbase.pm
Outdated
| @@ -20,6 +20,8 @@ use testapi qw(is_serial_terminal :DEFAULT); | |||
| use serial_terminal; | |||
| use Carp; | |||
| use Mojo::File 'path'; | |||
| use serial_terminal 'upload_file'; | |||
There was a problem hiding this comment.
You are already exporting it by default, and in line 20 it is already imported :D
There was a problem hiding this comment.
Oh, thx I overseen it :)
What do you mean with exporting it by default? I only see @EXPORT in serial_terminal.pm.
There was a problem hiding this comment.
Any symbol inside @EXPORT will be imported when use Foo; is used :), @EXPORT_OK on the other hand behaves a little bit different, as it will allow the module to export those symbols, but on demand (use Mojo::File qw(path) for example...)
There was a problem hiding this comment.
@foursixnine thx for pointing me at this. I twisted it.
What would you recommend, using the :DEFAULT export as long as it exists?
We thought about that too. But we took this approach as this will work, as long as you have a "almost silent" serial console. The |
VIRTIO_CONSOLE_NUM is used on QEMU backend, to enable more virtio-consoles. We need to add these consoles also in os-autoinst so the test can communicate with them.
Using serial terminal to transfer files between worker and SUT
Use serial_file::upload_file() for uploading log files. This avoid the need of working network after test. Allow upload files via serial on first console: If the test was run with VIRTIO_CONSOLE_NUM < 2, the upload should still work. The disadvantage is, that the file is visible on serial.txt in base64 format.
cfconrad
force-pushed
the
wicked_offline_upload
branch
from
f704c36
to
42c7619
Compare
In wicked testsuites, we often have the case, that we would like to transfer files between worker and SUT without having a working network connection network.
We are using a second virtio-terminal for it by adding
VIRTIO_CONSOLE_NUM=2.This PR needs following changes deployed:
Add quiet option to wait_serial() os-autoinst#1151
qemu: Multiple virtio-consoles os-autoinst#1156
Related ticket: https://progress.opensuse.org/issues/51098
Verification run: http://cfconrad-vm.qa.suse.de/tests/4666